Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make quereis to share the same server by default #270

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Make quereis to share the same server by default #270

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
12b3184
Make quereis to share the same server by default
limdor Jul 25, 2022
2756a69
Merge branch 'master' into shared_server_default
limdor Aug 22, 2022
5c511e0
Merge branch 'master' into shared_server_default
limdor Jan 2, 2024
9bab2f3
Update description to the setting default flip
limdor Jan 2, 2024
4a90863
Merge branch 'master' into shared_server_default
cameron-martin Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@
},
"bazel.queriesShareServer": {
"type": "boolean",
"default": false,
"default": true,
"description": "Use the same Bazel server for queries and builds. By default, vscode-bazel uses a separate server for queries so that they can be executed in parallel with builds. You can enable this setting if running multiple Bazel servers has a negative performance impact on your system, but you may experience degraded performance in Visual Studio Code for operations that require queries."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note, the description would have to be adapted because it assumes that default is false. Before I do that I would like to know the opinion of the contributors if they would agree on having default to true or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coeuvre @philwo any feedback?

limdor marked this conversation as resolved.
Show resolved Hide resolved
},
"bazel.queryOutputBase": {
Expand Down