Update CI to Ubuntu 20 and Node 20 #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2023
alexeagle
reviewed
Dec 1, 2023
| - | | ||
| sudo apt-get update | ||
| sudo apt-get install -y ca-certificates curl gnupg | ||
| sudo mkdir -p /etc/apt/keyrings |
There was a problem hiding this comment.
GitHub provides an easier way to do this: https://github.com/actions/setup-node
There was a problem hiding this comment.
This isn't a GitHub Actions workflow though, it's .bazelci (Buildkite).
|
@meisterT FYI, John and I discussed that it might be good to add another reviewer here |
meteorcloudy
approved these changes
Dec 4, 2023
|
I think that reviewers must be specifically authorized in repository settings somewhere in order to have their approvals unblock merging. Even with @meteorcloudy's approval I'm still getting the "Merging is blocked" message. |
|
@coeuvre is OOO this week unfortunately. Is there another person we could include in the CODEOWNERS file to avoid reviews being blocked? |
coeuvre
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes deprecation warnings and failures in CI. See for example, https://buildkite.com/bazel/vscode-bazel-vs-bazel/builds/1993#018c22c3-eae0-4d53-96c8-7c3afe453424.