Revert "Make queries share the same server by default (#270)" #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 64c9d7e. The underlying issue that this addresses is now fixed in Bazel 7.1.0. See bazel-contrib#216 and bazelbuild/bazel#21505.
jfirebaugh
approved these changes
Mar 12, 2024
|
Do we know which percentage of the user-base of this extension is already using Bazel 7.1? From the perspective of most Bazel 7.0 or 6.x users which might not be aware that this issue existed in Bazel < 7.1, this VSCode extension will seem broken. Should we rather auto-detect the Bazel version and set the setting automatically based on that? Or at least display a warning for older Bazel versions? |
|
Good point. I think displaying a message for older versions would be good, since this also has a manual workaround of adding the convenience symlinks to |
cameron-martin
added a commit
to cameron-martin/vscode-bazel
that referenced
this pull request
Apr 6, 2024
This flips the `bazel.queriesShareServer` default back to `true`, since I think it was a bit hasty in bazel-contrib#355 to break everyone not on the latest bazel version. Instead, I have added a section to the docs, linked from the setting, describing how to safely disable this option.
cameron-martin
added a commit
to cameron-martin/vscode-bazel
that referenced
this pull request
Apr 6, 2024
This flips the `bazel.queriesShareServer` default back to `true`, since I think it was a bit hasty in bazel-contrib#355 to break everyone not on the latest bazel version. Instead, I have added a section to the docs, linked from the setting, describing how to safely disable this option.
|
@vogelsgesang I've put up a PR to revert this change, plus add some docs in #367. |
cameron-martin
added a commit
to cameron-martin/vscode-bazel
that referenced
this pull request
Apr 6, 2024
This flips the `bazel.queriesShareServer` default back to `true`, since I think it was a bit hasty in bazel-contrib#355 to break everyone not on the latest bazel version. Instead, I have added a section to the docs, linked from the setting, describing how to safely disable this option.
cameron-martin
added a commit
that referenced
this pull request
Apr 8, 2024
This flips the `bazel.queriesShareServer` default back to `true`, since I think it was a bit hasty in #355 to break everyone not on the latest bazel version. Instead, I have added a section to the docs, linked from the setting, describing how to safely disable this option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 64c9d7e.
The underlying issue that this addresses is now fixed in Bazel 7.1.0. See #216 and bazelbuild/bazel#21505.