Add optional parameter of product_module_name #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be forwarded into the xctestrun file in the test name doesn't accurately reflect the module underneath
jerrymarino
reviewed
Jan 3, 2023
There was a problem hiding this comment.
This LGTM but 1 tweak 🚢
- the convention we use for bazel-ios is to create a distinguished branch of the fork e.g.
rules_ioson forks to avoid having to force push to master w/ branch protection if we have to start rebasing - for the rules_apple fork a similar suggestion - and rebase master to avoid having more than 1 commit on the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be forwarded into the xctestrun file in the test name doesn't accurately reflect the module underneath
Mirror of: google#50