Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add c-blosc2 2.12.0 #1349

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Add c-blosc2 2.12.0 #1349

merged 2 commits into from
Jan 22, 2024

Conversation

Vertexwahn
Copy link
Contributor

Add c-blosc2 2.12.0

@Vertexwahn
Copy link
Contributor Author

Need skip-url-stability-check label.

@fmeum fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Jan 21, 2024
@Vertexwahn Vertexwahn force-pushed the c-blosc2-2.12.0 branch 2 times, most recently from bf56e5b to 5292b86 Compare January 21, 2024 21:24
@Wyverald Wyverald enabled auto-merge (squash) January 22, 2024 18:59
@Wyverald Wyverald merged commit 3358385 into bazelbuild:main Jan 22, 2024
9 checks passed
@Vertexwahn Vertexwahn mentioned this pull request Jan 29, 2024
1 task
@phaedon
Copy link
Contributor

phaedon commented Feb 2, 2024

Does this build rule need the visibility set to public?

in cc_library rule //openvdb:openvdb: target '@@c-blosc2~2.12.0//:c-blosc2' is not visible from target '//openvdb:openvdb'. Check the visibility declaration of the former target if you think the dependency is legitimate

[edit]
Hmm, but this commit doesn't seem to fix the problem:
bazel test ... --registry=https://raw.githubusercontent.com/phaedon/bazel-central-registry/blosc-visibility

@Vertexwahn
Copy link
Contributor Author

@phaedon You are right visibility = ["//visibility:public"], is missing. Sorry for this. Can you create a version 2.12.0.bcr.1 (i.e. create a folder 2.12.0.bcr.1 - copy the contents from 2.12.0 with the visibility change (as done in your local fork?)

@phaedon
Copy link
Contributor

phaedon commented Feb 2, 2024

Will do. So I understand, did my local fork not work because it has to be set up with a different version number?

@Vertexwahn
Copy link
Contributor Author

@phaedon Depends on the order of registries in your .bazlrc file - e.g.:

common --registry=https://raw.githubusercontent.com/Vertexwahn/bazel-registry/main/ 
common --registry=https://raw.githubusercontent.com/bazelboost/registry/main
common --registry=https://bcr.bazel.build

If I am not wrong this is in an first come first served order. Maybe c-blosc2-2.12.0 was fetched from https://bcr.bazel.build since it was the first registry defined? Nevertheless, it is hidden without visibility- it should definitely be fixed.

@Vertexwahn Vertexwahn deleted the c-blosc2-2.12.0 branch February 11, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants