Update bcr_validation.py to handle overlay files #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalten
force-pushed
the
overlay_bcr-validation
branch
from
1e7d997 to
106285b
Compare
fmeum
previously approved these changes
Jun 14, 2024
hofbi
reviewed
Jun 14, 2024
bazel-io
dismissed
fmeum’s stale review
Require module maintainers' approval for newly pushed changes.
fmeum
approved these changes
Jun 14, 2024
This was referenced Jul 22, 2024
|
how do you handle having a module then be backwards comptable for non-overlay Bazel versions? I thought about maybe turning the overlay's via the NGINX server as a PATCH file live? The MODULE.bazel also doesn't have a bazel version compatability. It should be > 7.X right? |
Needs to be >= 7.2.1 due to bazelbuild/bazel#22811 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow using the new overlay format (#1566)
Tested with #2240
This is an alternative to #2046 (which I hadn't seen previously 🙈 )