Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #2563

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

bazel-io commented Aug 7, 2024

Hello @alexeagle, @thesayyn, modules you maintain (rules_oci) have been updated in this PR. Please review the changes.

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@seh
Copy link
Contributor

seh commented Aug 14, 2024

Are we still expecting to publish this version, or will there be a third beta release coming that will make it through?

@thesayyn
Copy link
Contributor

Are we still expecting to publish this version, or will there be a third beta release coming that will make it through?

I have no idea why we get this error. It's all green in rules_oci CI.

@Wyverald
Copy link
Member

Your release archive doesn't contain the "examples" directory.

@alexeagle
Copy link
Contributor

Oh that's simple to explain: https://github.com/bazel-contrib/rules_oci/blob/main/.gitattributes#L12-L13 has been there for five months.
When we added this line last month
https://github.com/bazel-contrib/rules_oci/blob/main/e2e/smoke/BUILD.bazel#L68
we broke it by having e2e depend on examples.

@thesayyn
Copy link
Contributor

thesayyn commented Sep 6, 2024

I believe we can close this.

@Wyverald Wyverald closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants