rm last usage of --experimental_build_setting_api

[juliexxia]

No description provided.

[c-parsons]

Failure here looks legitimate. Looks like Stardoc still reflects this flag as being false. You have two options here:

1. Update Stardoc version (not sure when the last Stardoc release was relative to this flag change, but you may need to rebuild/release a new Stardoc. Then, update skylib's dependency on Stardoc to the new version. Then, you should be able to carry on with this commit.

OR

2. Revert this commit and keep status quo; when skylib needs to update stardoc version, we will need to also include the diff of this commit.

[juliexxia]

Not sure why this is failing with the --experimental_build_setting_api check. That flag has defaulted to true for ~a year now in bazel and it seems like the checks are running 3.4.1 so not a super old version or anything

[c-parsons]

It looks like stardoc jars were updated 10 months ago (bazelbuild/stardoc@9346c62)

But this flag was flipped 13 months ago
(bazelbuild/bazel@f113c44)

So it must just be the case that skylib is depending on a very old version of Stardoc, via the federation tar.
Perhaps you can update that dependency here and this should be fine?

[aiuto]

Hi Julie. I made a PR to update stardoc in the federation. If you approve that I can make a new release of that, and you can update the skylib dep in your PR. bazelbuild/bazel-federation#119

…

On Tue, Jul 28, 2020 at 1:12 PM c-parsons ***@***.***> wrote: It looks like stardoc jars were updated 10 months ago (bazelbuild/stardoc@ 9346c62 <bazelbuild/stardoc@9346c62> ) But this flag was flipped 13 months ago ***@***.*** <bazelbuild/bazel@f113c44> ) So it must just be the case that skylib is depending on a *very* old version of Stardoc, via the federation tar. Perhaps you can update that dependency here and this should be fine? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#260 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXHHHFG5M6PKS6XUXO2CU3R54AMHANCNFSM4PKWSHNA> .

[juliexxia]

@aiuto that bazel_federation update got this all fixed thanks much!

[aiuto]

Great.

…

On Thu, Jul 30, 2020 at 5:01 PM Julie ***@***.***> wrote: @aiuto <https://github.com/aiuto> that bazel_federation update got this all fixed thanks much! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#260 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXHHHARZGNPJ53Y5FYMTNTR6HNTFANCNFSM4PKWSHNA> .