Add subpackages module to skylib to support new bazel native.subpackages #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a relatively simple addition to unittest that statically creates rules that either explicitly fail or not depending on if the test case, evaluated entirely in loading phase, resulted in the expected state or not.
|
I fournd typo. |
tetromino
requested changes
Feb 5, 2022
…kages This adds support for friendly APIs on top of the new native.subpackages support added to Bazel. This allows code to use subpackage, if the Bazel version supports it, test for packages existing and construct targets based on relative subackages. This Pull requires support for 'loadingtest' has been added to the 'unittest' module.
kkress
force-pushed
the
add_subpackages
branch
from
ae85cd2 to
472c212
Compare
|
OK I think that did it, sorry my git/github foo is not great so there are a bunch of commits :/ |
…plate) And also ensure we test non-fully-qualified output.
tetromino
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stacked PR on top of #347 (commit #1), this should not be merged until that PR is accepted and merged.
This PR adds some simple utility functions for the new
native.subpackagesloading phase function added to bazel. It allows callers to check for support of the function in bazel before calling and provides some useful utility.