Remove unused, empty //rules:bins filegroup, allowing us to simplify distribution/BUILD #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…distribution/BUILD //rules:bins has not been used since 14f17ae
tetromino
requested review from
brandjon,
comius,
hvadehra and
c-mita
as code owners
comius
approved these changes
Mar 10, 2022
|
@tetromino and @comius can you tell when will be a release with this fix? And which release will be? |
|
@cafsenra, we can make a point release for this. Is it breaking you because you turn on |
tetromino
added a commit
that referenced
this pull request
Mar 10, 2022
Make a point release to unbreak users who set `--incompatible_disallow_empty_glob`. See discussion in #359
|
@tetromino yes it is that. Thank you, a new release will be welcome ;) |
ngiloq6
added a commit
to ngiloq6/bazel-skylib
that referenced
this pull request
Aug 17, 2024
Make a point release to unbreak users who set `--incompatible_disallow_empty_glob`. See discussion in bazelbuild/bazel-skylib#359
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//rules:bins has not been used since 14f17ae
Alternative to #358