Skip to content

Commit

Permalink
Make cc_toolchain.cpu and cc_toolchain.compiler nonconfigurable
Browse files Browse the repository at this point in the history
They should be used during toolchain selection (will happen in unknown commit). I
think it's an oversight that they are configurable now.

#6072

RELNOTES: None
PiperOrigin-RevId: 212791669
  • Loading branch information
hlopko authored and Copybara-Service committed Sep 13, 2018
1 parent 8662202 commit 39cca12
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ public RuleClass build(RuleClass.Builder builder, RuleDefinitionEnvironment env)
.requiresConfigurationFragments(CppConfiguration.class, PlatformConfiguration.class)
.advertiseProvider(TemplateVariableInfo.class)
.add(attr("output_licenses", LICENSE))
.add(attr("cpu", STRING).mandatory())
.add(attr("compiler", STRING))
.add(attr("cpu", STRING).nonconfigurable("Used in configuration creation").mandatory())
.add(attr("compiler", STRING).nonconfigurable("Used in configuration creation"))
.add(
attr("all_files", LABEL)
.legacyAllowAnyFileType()
Expand Down

0 comments on commit 39cca12

Please sign in to comment.