Skip to content

Commit

Permalink
Fix the images in the recursive WS design doc
Browse files Browse the repository at this point in the history
Somehow they were all uploaded as 0 bytes, but that's okay because the URLs
in the design doc were wrong, anyway.

Relavant design doc: https://bazel.build/designs/2016/09/19/recursive-ws-parsing.html, issue #1943.

--
PiperOrigin-RevId: 145799866
MOS_MIGRATED_REVID=145799866
  • Loading branch information
kchodorow authored and meteorcloudy committed Jan 30, 2017
1 parent c637fbb commit d7e965a
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 3 deletions.
Binary file modified site/assets/ws-diamond.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified site/assets/ws-line.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified site/assets/ws-multiline.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions site/designs/_posts/2016-09-19-recursive-ws-parsing.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ about don't need to be resolved.
Suppose we have a main repository that depends on repo x, and x depends on repo
y:

<img src="/assets/ws-line.jpg" class="img-responsive">
<img src="/assets/ws-line.png" class="img-responsive">

In this case, version 1 of "foo" wins. This way, if a library has already
figured out which version works for them, its reverse dependencies do not have
Expand All @@ -54,7 +54,7 @@ If there is no obvious hierarchy and multiple versions are specified, error out.
Report what each chain of dependencies was that wanted the dep and at which
versions:

<img src="/assets/ws-multiline.jpg" class="img-responsive">
<img src="/assets/ws-multiline.png" class="img-responsive">

In this case, Bazel would error out with:

Expand All @@ -68,7 +68,7 @@ vs. bazel-external/a/WORKSPACE:2 repository(name = 'foo' version = '2')

This is also the case with diamond dependencies:

<img src="/assets/ws-diamond.jpg" class="img-responsive">
<img src="/assets/ws-diamond.png" class="img-responsive">

This would print:

Expand Down

0 comments on commit d7e965a

Please sign in to comment.