Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Error Prone dependency causes failures with some checks enabled #1008

Closed
ekuefler opened this issue Mar 3, 2016 · 4 comments
Closed

Missing Error Prone dependency causes failures with some checks enabled #1008

ekuefler opened this issue Mar 3, 2016 · 4 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug
Milestone
1.0

Comments

@ekuefler
Copy link
Contributor

ekuefler commented Mar 3, 2016

If I try to build something that has a string equality error with --javacopt="-Xep:StringEquality:ERROR" turned on, I get an error containing the following:

com.google.common.util.concurrent.ExecutionError: java.lang.NoClassDefFoundError: org/checkerframework/javacutil/AnnotationProvider

Looks like Bazel is missing a transitive dep of Error Prone. (This was run on Bazel 0.1.4 just in case it's been added since then)
@kchodorow
Copy link
Contributor

Still an issue at head.

@kchodorow kchodorow added type: bug P2 We'll consider working on this in future. (Assignee optional) Native rules (Java / C++ / Python) labels Mar 3, 2016
@ulfjack
Copy link
Contributor

ulfjack commented May 4, 2016

@eaftan @cushon

@ulfjack ulfjack added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Jun 16, 2016
@ulfjack ulfjack added this to the 1.0 milestone Jun 16, 2016
@cushon
Copy link
Contributor

cushon commented Jun 21, 2016

07caf82 wasn't a complete fix, I missed this: http://mvnrepository.com/artifact/org.checkerframework/javacutil/1.8.10

@cushon
Copy link
Contributor

cushon commented Aug 4, 2016

I think @damienmg fixed this with f6c24de.

@quittle quittle mentioned this issue May 2, 2018
Closed
cushon added a commit to cushon/bazel that referenced this issue May 4, 2018
@cushon
Add a missing dependency from checker framework dataflow to javacutils
bd7db6a 
Fixes bazelbuild#5134, bazelbuild#1008

Change-Id: Ic34e26b17b2ebee75f36e9f56f8e5c2ec6205bc0
@cushon cushon mentioned this issue May 4, 2018
Closed
bazel-io pushed a commit that referenced this issue May 28, 2018
@cushon @buchgr
Add a missing dependency from checker framework dataflow to javacutils
eca7b81 
Fixes #5134, #1008

Change-Id: Ic34e26b17b2ebee75f36e9f56f8e5c2ec6205bc0
lfpino pushed a commit that referenced this issue May 28, 2018
@cushon @lfpino
Add a missing dependency from checker framework dataflow to javacutils
3fc9209 
Fixes #5134, #1008

Change-Id: Ic34e26b17b2ebee75f36e9f56f8e5c2ec6205bc0
@cushon cushon closed this as completed Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
4 participants
@kchodorow @cushon @ekuefler @ulfjack