Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.4.0] Add --incompatible_merge_fixed_and_default_shell_env #19312

Closed
bazel-io opened this issue Aug 23, 2023 · 3 comments
Closed

[6.4.0] Add --incompatible_merge_fixed_and_default_shell_env #19312

bazel-io opened this issue Aug 23, 2023 · 3 comments
Milestone
6.4.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #18235
@bazel-io bazel-io added this to the 6.4.0 release blockers milestone Aug 23, 2023
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts. Please resolve manually.
cc: @bazelbuild/triage

@fmeum fmeum mentioned this issue Aug 24, 2023
Merged
@fmeum
Copy link
Collaborator

fmeum commented Aug 24, 2023

@iancha1992 I submitted #19319 with a manual cherry-pick.

@iancha1992
Copy link
Member

Cherry-picked in #19319 by @fmeum

iancha1992 added a commit that referenced this issue Sep 8, 2023
@fmeum @comius @iancha1992
[6.4.0] Add --incompatible_merge_fixed_and_default_shell_env (#19319)
6052b8b 
With the new flag, Starlark actions that specify both `env` and
`use_default_shell_env` will no longer have `env` ignored. Instead, the
values of `env` will override the default shell environment.

This allows Starlark actions to both pick up user-configured variables
such as `PATH` from the shell environment as well as set variables to
fixed values required for the action, e.g., variables provided by the
C++ toolchain.

Rationale for having `env` override the default shell env: The rules
know best which values they have to set specific environment variables
to in order to successfully execute an action, so a situation where
users break an action by a globally applied `--action_env` is prevented.
If users really do have to be able to modify an environment variables
fixed by the rule, the rule can always make this configurable via an
attribute.

Work towards #5980
Fixes #12049

Closes #18235.

Commit
d1fdc53

PiperOrigin-RevId: 559506535
Change-Id: I7ec6ae17b076bbca72fab8394f3a8b3e4f9ea9d8

Fixes #19312

---------

Co-authored-by: Ivo List <[email protected]>
Co-authored-by: Ian (Hee) Cha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.0 release blockers
Development

No branches or pull requests
3 participants
@fmeum @bazel-io @iancha1992