Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.2.0] Improve unavailable Xcode message for Bzlmod #21938

Closed
bazel-io opened this issue Apr 9, 2024 · 3 comments
Closed

[7.2.0] Improve unavailable Xcode message for Bzlmod #21938

bazel-io opened this issue Apr 9, 2024 · 3 comments
Assignees
@brentleyjones
Milestone
7.2.0 release blo...

Comments

@bazel-io
Copy link
Member

bazel-io commented Apr 9, 2024

Forked from #21937
@bazel-io bazel-io added this to the 7.2.0 release blockers milestone Apr 9, 2024
@brentleyjones
Copy link
Contributor

I will make the PR for this, since it will have merge conflicts for the automatic cherry-pick.

@brentleyjones brentleyjones self-assigned this Apr 9, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/starlark/builtins_bzl/common/cc/cc_toolchain_exec.bzl
src/main/starlark/builtins_bzl/common/cc/cc_toolchain_target.bzl
src/main/starlark/builtins_bzl/common/xcode/xcode_config.bzl

cc: @bazelbuild/triage

@brentleyjones brentleyjones mentioned this issue Apr 12, 2024
Merged
@iancha1992
Copy link
Member

Cherry-picked in #21990 by @brentleyjones

github-merge-queue bot pushed a commit that referenced this issue Apr 15, 2024
@brentleyjones
[7.2.0] Improve unavailable Xcode message for Bzlmod (#21990)
81fc95f 
Context:
https://bazelbuild.slack.com/archives/C014RARENH0/p1709547684815279?thread_ts=1709324251.252319&cid=C014RARENH0

Closes #21938.

PiperOrigin-RevId: 623421163
Change-Id: I450b1b1e3b3c0544b391e571911f62f0709aa62c (cherry picked from
commit c8fcfd4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brentleyjones brentleyjones

Labels
None yet
Projects
None yet
Milestone
7.2.0 release blockers
Development

No branches or pull requests
3 participants
@brentleyjones @bazel-io @iancha1992