-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Starlark options parser #22365
Labels
P2
We'll consider working on this in future. (Assignee optional)
team-Configurability
platforms, toolchains, cquery, select(), config transitions
type: feature request
Comments
katre
added
type: feature request
P2
We'll consider working on this in future. (Assignee optional)
team-Configurability
platforms, toolchains, cquery, select(), config transitions
labels
May 14, 2024
This is motivated by code cleanups necessary for platform based flags. |
copybara-service bot
pushed a commit
that referenced
this issue
May 14, 2024
Work towards starlark options parser cleanup: #22365. PiperOrigin-RevId: 633649715 Change-Id: Ie9820981fdcbbcea49ebd0c8042aeb621e378492
copybara-service bot
pushed a commit
that referenced
this issue
May 14, 2024
Work towards starlark options parser cleanup: #22365. PiperOrigin-RevId: 633649782 Change-Id: I73180180142b5b23e91f1ee8c845ea606cfdc85e
copybara-service bot
pushed a commit
that referenced
this issue
May 14, 2024
Work towards starlark options parser cleanup: #22365. PiperOrigin-RevId: 633670413 Change-Id: If56ed3a805d7540f8100ae344170991c961de53a
copybara-service bot
pushed a commit
that referenced
this issue
May 14, 2024
Work towards starlark options parser cleanup: #22365. PiperOrigin-RevId: 633687955 Change-Id: I1e31b90c2ae701c29f5a36117f9cf0079e1e8d1b
copybara-service bot
pushed a commit
that referenced
this issue
May 20, 2024
…o a subclass. Work towards starlark options parser cleanup: #22365. PiperOrigin-RevId: 635437320 Change-Id: Ib7baa5b880a091d747e0d296761eb50753b29e91
This probably also includes rationalizing and/or removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P2
We'll consider working on this in future. (Assignee optional)
team-Configurability
platforms, toolchains, cquery, select(), config transitions
type: feature request
StarlarkOptionsParser
is part of overall options parsing but still separate: it uses an entirely different API fromOptionsParser
and many code paths that handle options only handle native options as a result.Ideally, native flags (based on
OptionsBase
and@Option
) would use the same API as Starlark build settings.An ideal end state API might look something like this:
OptionsParser
that is responsible for splitting flags into keys and values--flag value
and--flag=value
syntaxno
boolean-negation prefixOptionsBase
subclasses, annotated with@Option
All of this is ambitious and won't happen soon, but I do plan to start some degree of convergence in order to durably expose Starlark option metadata via the existing
OptionDefinition
type.The text was updated successfully, but these errors were encountered: