Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows,java_binary launcher: support jar files on multiple drives #5135

Closed
laszlocsomor opened this issue May 2, 2018 · 7 comments
Closed

Windows,java_binary launcher: support jar files on multiple drives #5135

laszlocsomor opened this issue May 2, 2018 · 7 comments
Assignees
@meteorcloudy
Labels
P1 I'll work on this now. (Assignee required) platform: windows type: feature request

Comments

@laszlocsomor
Copy link
Contributor

Feature requests: what underlying problem are you trying to solve with this feature?

The java_binary launcher cannot create a classpath jar if the jar files are on different drives.

What operating system are you running Bazel on?

Windows 10.

What's the output of bazel info release?

release 0.13.0

Have you found anything relevant by searching the web?

#5125 (comment)
@laszlocsomor
Copy link
Contributor Author

/cc @meteorcloudy

@meteorcloudy
Copy link
Member

Looks like creating junctions for those jars is the only option?

@meteorcloudy meteorcloudy added the P2 We'll consider working on this in future. (Assignee optional) label May 2, 2018
@meteorcloudy meteorcloudy self-assigned this May 2, 2018
@laszlocsomor
Copy link
Contributor Author

That's my best idea too.

@laszlocsomor laszlocsomor mentioned this issue May 2, 2018
Closed
@meteorcloudy
Copy link
Member

I'll find a time to take care of this!

@laszlocsomor
Copy link
Contributor Author

Thank you @meteorcloudy ! You could use the junction creator in

bazel/src/main/native/windows/file.h

Line 85 in 56fbc99

wstring CreateJunction(const wstring& junction_name,

@meteorcloudy
Copy link
Member

Thanks!

@laszlocsomor laszlocsomor added P1 I'll work on this now. (Assignee required) and removed P2 We'll consider working on this in future. (Assignee optional) labels May 2, 2018
@laszlocsomor
Copy link
Contributor Author

P1 because it blocks #5125 which is also P1.

meteorcloudy added a commit to meteorcloudy/bazel that referenced this issue May 4, 2018
@meteorcloudy
Windows, Java launcher: Support jar files under different drives
c0028be 
Create junctions to jar's directory when java launcher and its jar are under different drives

Fixed bazelbuild#5135

Change-Id: I21c5b28f5f36c1fe234f8b781fe40d526db846cc
@meteorcloudy meteorcloudy mentioned this issue May 4, 2018
Closed
@laszlocsomor laszlocsomor mentioned this issue May 14, 2018
Closed
lfpino pushed a commit that referenced this issue May 14, 2018
@meteorcloudy @lfpino
Windows, Java launcher: Support jar files under different drives
486c983 
Create junctions to jar's directory when java launcher and its jar are under different drives

Fixed #5135

Change-Id: I21c5b28f5f36c1fe234f8b781fe40d526db846cc
PiperOrigin-RevId: 196477704
lfpino pushed a commit that referenced this issue May 17, 2018
@meteorcloudy @lfpino
Windows, Java launcher: Support jar files under different drives
769976c 
Create junctions to jar's directory when java launcher and its jar are under different drives

Fixed #5135

Change-Id: I21c5b28f5f36c1fe234f8b781fe40d526db846cc
PiperOrigin-RevId: 196477704
lfpino pushed a commit that referenced this issue May 24, 2018
@meteorcloudy @lfpino
Windows, Java launcher: Support jar files under different drives
cc4ce1d 
Create junctions to jar's directory when java launcher and its jar are under different drives

Fixed #5135

Change-Id: I21c5b28f5f36c1fe234f8b781fe40d526db846cc
PiperOrigin-RevId: 196477704
ulfjack pushed a commit that referenced this issue May 25, 2018
@meteorcloudy @ulfjack
Windows, Java launcher: Support jar files under different drives
8b830ad 
Create junctions to jar's directory when java launcher and its jar are under different drives

Fixed #5135

Change-Id: I21c5b28f5f36c1fe234f8b781fe40d526db846cc
PiperOrigin-RevId: 196477704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meteorcloudy meteorcloudy

Labels
P1 I'll work on this now. (Assignee required) platform: windows type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meteorcloudy @laszlocsomor