-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flip --incompatible_blacklisted_protos_requires_proto_info #12037
Conversation
What about the big pile of failing presubmits? |
The Bazel repo wasn't ready for flipping the flag yet, upgrading Protobuf to 3.13.0 fixed that (#12108). @lberki Could you already run this through internal presubmit to see whether there's anything needed before we can merge it for Bazel 4.0? |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
(sorry this requested so many reviewers, I made a mistake when rebase the change) |
Fixes #11694