Remote: Do not upload empty output to remote cache. #13594
Closed
+104
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting! 🤔 But if it's in the spec, yeah, why not. ^^ |
philwo
approved these changes
Jun 22, 2021
Closed
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jul 15, 2021
An unintended side-effect of change cc2b3ec is that zero-sized blob won't be uploaded to gRPC cache. However, the behavior is existed for a long time and the REAPI spec is also updated accordingly. This change makes the behavior explicit and brings it to other remote cache backends. Context bazelbuild#11063. Fixes bazelbuild#13349. Closes bazelbuild#13594. PiperOrigin-RevId: 384457129
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jul 15, 2021
An unintended side-effect of change cc2b3ec is that zero-sized blob won't be uploaded to gRPC cache. However, the behavior is existed for a long time and the REAPI spec is also updated accordingly. This change makes the behavior explicit and brings it to other remote cache backends. Context bazelbuild#11063. Fixes bazelbuild#13349. Closes bazelbuild#13594. PiperOrigin-RevId: 384457129
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jul 15, 2021
An unintended side-effect of change cc2b3ec is that zero-sized blob won't be uploaded to gRPC cache. However, the behavior is existed for a long time and the REAPI spec is also updated accordingly. This change makes the behavior explicit and brings it to other remote cache backends. Context bazelbuild#11063. Fixes bazelbuild#13349. Closes bazelbuild#13594. PiperOrigin-RevId: 384457129
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jul 15, 2021
An unintended side-effect of change cc2b3ec is that zero-sized blob won't be uploaded to gRPC cache. However, the behavior is existed for a long time and the REAPI spec is also updated accordingly. This change makes the behavior explicit and brings it to other remote cache backends. Context bazelbuild#11063. Fixes bazelbuild#13349. Closes bazelbuild#13594. PiperOrigin-RevId: 384457129
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jul 16, 2021
An unintended side-effect of change cc2b3ec is that zero-sized blob won't be uploaded to gRPC cache. However, the behavior is existed for a long time and the REAPI spec is also updated accordingly. This change makes the behavior explicit and brings it to other remote cache backends. Context bazelbuild#11063. Fixes bazelbuild#13349. Closes bazelbuild#13594. PiperOrigin-RevId: 384457129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unintended side-effect of change cc2b3ec is that zero-sized blob won't be uploaded to gRPC cache. However, the behavior is existed for a long time and the REAPI spec is also updated accordingly. This change makes the behavior explicit and brings it to other remote cache backends.
Context #11063.
Fixes #13349.