Fix up @build_tools//tools/java package #13790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @comius - apologies for the follow-up (and so late after the original)! |
illicitonion
force-pushed
the
fix-java-stub-template
branch
from
2612276 to
d324457
Compare
comius
requested changes
Aug 4, 2021
tools/java/BUILD
Outdated
| srcs = ["BUILD.for_buildtools"], | ||
| outs = ["BUILD.bazel"], | ||
| cmd = "cp $< $@", | ||
| ) |
There was a problem hiding this comment.
I'd prefer if BUILD.tools file is added to the repo and used in the filegroup, like it's done in other directories (tools/jdk, tools/java/runfiles).
java_stub_template.txt needed genrule with cp, but in general I'd prefer it's avoided.
There was a problem hiding this comment.
You also need to add BUILD.tools to srcs filegroup in tools/java/BUILD
illicitonion
force-pushed
the
fix-java-stub-template
branch
from
d324457 to
31996b2
Compare
comius
approved these changes
Aug 4, 2021
illicitonion
force-pushed
the
fix-java-stub-template
branch
from
31996b2 to
882ad99
Compare
bazelbuild#12994 added the file, but it's currently exposed as: `@build_tools//tools:java/java_stub_template.txt` This fixes it up to be properly exposed as: `@build_tools//tools/java:java_stub_template.txt` Which makes more sense :)
illicitonion
force-pushed
the
fix-java-stub-template
branch
from
882ad99 to
f1b22cd
Compare
illicitonion
added a commit
to illicitonion/rules_kotlin
that referenced
this pull request
Dec 5, 2023
This was added in bazelbuild/bazel#12994 (and fixed in bazelbuild/bazel#13790). This has been included in all Bazel releases since 5.0.0, which is the minimum supported Bazel version of rules_kotlin according to https://github.com/bazelbuild/rules_kotlin/blob/master/README.md This prevents having a build-time dependency on access to raw.githubusercontent.com.
illicitonion
added a commit
to illicitonion/rules_kotlin
that referenced
this pull request
Dec 5, 2023
This was added in bazelbuild/bazel#12994 (and fixed in bazelbuild/bazel#13790). This has been included in all Bazel releases since 5.0.0, which is the minimum supported Bazel version of rules_kotlin according to https://github.com/bazelbuild/rules_kotlin/blob/master/README.md This prevents having a build-time dependency on access to raw.githubusercontent.com.
illicitonion
added a commit
to illicitonion/rules_kotlin
that referenced
this pull request
Dec 5, 2023
This was added in bazelbuild/bazel#12994 (and fixed in bazelbuild/bazel#13790). This has been included in all Bazel releases since 5.0.0, which is the minimum supported Bazel version of rules_kotlin according to https://github.com/bazelbuild/rules_kotlin/blob/master/README.md This prevents having a build-time dependency on access to raw.githubusercontent.com.
restingbull
pushed a commit
to bazelbuild/rules_kotlin
that referenced
this pull request
Dec 8, 2023
This was added in bazelbuild/bazel#12994 (and fixed in bazelbuild/bazel#13790). This has been included in all Bazel releases since 5.0.0, which is the minimum supported Bazel version of rules_kotlin according to https://github.com/bazelbuild/rules_kotlin/blob/master/README.md This prevents having a build-time dependency on access to raw.githubusercontent.com.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12994 added the file, but it's
currently exposed as:
@build_tools//tools:java/java_stub_template.txtThis fixes it up to be properly exposed as:
@build_tools//tools/java:java_stub_template.txtWhich makes more sense :)