Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherrypick] Remote: Cache merkle trees #14185

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

coeuvre
Copy link
Member

@coeuvre coeuvre commented Oct 28, 2021

Original commit: becd149

When --experimental_remote_merkle_tree_cache is set, Merkle tree calculations are cached for each node in the input NestedSets (depsets). This drastically improves the speed when checking for remote cache hits. One example reduced the Merkle tree calculation time from 78 ms to 3 ms for 3000 inputs.

The memory foot print of the cache is controlled by --experimental_remote_merkle_tree_cache_size.

The caching is discarded after each build to free up memory, the cache setup time is negligible.

Fixes bazelbuild#10875.

Closes bazelbuild#13879.

PiperOrigin-RevId: 405793372
@coeuvre coeuvre requested a review from Wyverald October 28, 2021 09:00
@coeuvre coeuvre requested a review from a team as a code owner October 28, 2021 09:00
@google-cla google-cla bot added the cla: yes label Oct 28, 2021
@Wyverald Wyverald changed the base branch from master to release-5.0.0rc1 October 28, 2021 09:47
@Wyverald Wyverald merged commit 3947c83 into bazelbuild:release-5.0.0rc1 Oct 28, 2021
@coeuvre coeuvre deleted the re-cherrypicks branch November 8, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants