Simplify WORKSPACE.bzlmod and add CI test for Bzlmod #14312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- All workspace suffix are removed from WORKSPACE.bzlmod, since we get all dependencies and toolchains from Bzlmod. - Added build:bzlmod bazelrc section, we have to override two flags to make sure toolchains are picked up correctly. - Added zstd-jni as dependency - Added postsubmit_bzlmod.yml for testing the Bzlmod build.
meisterT
approved these changes
Nov 23, 2021
comius
approved these changes
Nov 23, 2021
Bencodes
pushed a commit
to Bencodes/bazel
that referenced
this pull request
Jan 10, 2022
- All workspace suffix are removed from WORKSPACE.bzlmod, since we get all dependencies and toolchains from Bzlmod. - Added build:bzlmod bazelrc section, we have to override two flags to make sure toolchains are picked up correctly. - Added zstd-jni as dependency - Added postsubmit_bzlmod.yml for testing the Bzlmod build. Tested at https://buildkite.com/bazel/bazel-bazel-with-bzlmod/builds/3 Closes bazelbuild#14312. PiperOrigin-RevId: 411855954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all dependencies and toolchains from Bzlmod.
make sure toolchains are picked up correctly.
Tested at https://buildkite.com/bazel/bazel-bazel-with-bzlmod/builds/3