-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow locally build actions with scrubber #21288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add an integration test verifying that the fallback to local execution works? (Search for test_cache_key_scrubbing
in //src/test/shell/bazel/remote/remote_execution_test.sh
.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. We should also amend the description for the --experimental_remote_scrubbing_config
flag, but I will do that myself when I import it.
@bazel-io fork 7.1.0 |
…on is enabled. As discussed in bazelbuild#20070, it's sometimes useful to scrub actions in a build that is otherwise remote. Closes bazelbuild#21288. PiperOrigin-RevId: 607723207 Change-Id: I31403de74fb81d07aac765cca68b2991b0230496
… execution is enabled. (#21384) As discussed in #20070, it's sometimes useful to scrub actions in a build that is otherwise remote. Closes #21288. Commit 8e0343c PiperOrigin-RevId: 607723207 Change-Id: I31403de74fb81d07aac765cca68b2991b0230496 Co-authored-by: Artem V. Navrotskiy <[email protected]>
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Since cannot run remote cache key scrubbing action with remote execution, run this actions only locally. Actions without scrubber can still be executed remotely.
The part from #20070 that didn't cause much rejection.