Let native Turbine image find ct.sym with non-hermetic java_runtime

[fmeum]

Work towards #21604

[fmeum]

CC @coeuvre

I haven't managed to write a test for this (it fails with a different error in Turbine), but verified that this fixes the reproducer.

not a supported release: OptionalInt[11]

Usage: turbine [options]

Options:
  --output
    The jar output file.
  --sources
    The sources to compile.
  --source_jars
    jar archives of sources to compile.
  --classpath
    The compilation classpath.
  --bootclasspath
    The compilation bootclasspath.
  --help
    Print this usage statement.
  @<filename>
    Read options and filenames from file.

[coeuvre]

Thanks for the fix!

[fmeum]

@bazel-io fork 7.2.0

[coeuvre]

@meteorcloudy can we also include this fix in 7.1.0? The risk should be pretty low.

[hvadehra]

It would be really nice to have a test, given how non-localized the involved interactions are (bazel, rules_java, java_tools, etc). Otherwise, LGTM to me as an isolated improvement¹ (and we can always try adding a test in a followup).

Footnotes

1. I don't think this is the correct resolution to https://github.com/bazelbuild/bazel/issues/21604 but I'll discuss more about that there. ↩

[hvadehra]

Approving, @fmeum if adding a test is too problematic, please let me know and we can merge this anyways.

[meteorcloudy]

@coeuvre We just cut rc2 for 7.1.0 and were hoping it would be the last rc. Maybe we can backport this change along with all other JDK 21 changes all together in 7.2.0?

[coeuvre]

SG!

[coeuvre]

I am going to import this PR now. @fmeum: feel free to add test in a separate PR.

[fmeum]

@hvadehra I now understood that my attempts at testing this failed since local_java_repository does specify srcs and just wasn't affected by the bug. It looks like neither java_runtime(java_home = ...) nor local_java_runtime have any integration test coverage in Bazel, so I'm not sure whether and how to test this new behavior.

[coeuvre]

@bazel-io fork 7.1.1

[iancha1992]

The changes in this PR have been included in Bazel 7.1.1 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.1.1rc1. Thanks!