Show display form labels in java_* buildozer fixups
#21827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
20486-native-label-args
branch
4 times, most recently
from
5928716 to
04f69a2
Compare
|
Stacked on #21702 |
fmeum
force-pushed
the
20486-native-label-args
branch
from
04f69a2 to
098bacf
Compare
fmeum
requested review from
gregestren and
justinhorvitz
and removed request for
a team,
lberki and
gregestren
github-actions
bot
added
team-Configurability
|
Can you sync to pick up 9d3a8b0? |
fmeum
force-pushed
the
20486-native-label-args
branch
from
098bacf to
04c53a0
Compare
Done |
justinhorvitz
approved these changes
Apr 5, 2024
| * Concatenates the passed prefix string and the label using {@link Label#getDisplayForm}, which | ||
| * is identical to {@link Label#getCanonicalForm()} for main repo labels. | ||
| */ | ||
| public Builder addPrefixedLabel( |
There was a problem hiding this comment.
Please add @CanIgnoreReturnValue to all the Builder-returning public methods, or else our ErrorProne checks are going to spam us.
There was a problem hiding this comment.
I added annotations to all methods, not just the ones I added (hope that's what you meant).
justinhorvitz
approved these changes
Apr 5, 2024
|
@bazel-io fork 7.2.0 |
|
Hi @justinhorvitz, Since i can see that this PR has been approved, Please let me know whether i should proceed with importing it. Thanks! |
|
Yes please, ready for import. |
sgowroji
added
awaiting-PR-merge
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Apr 9, 2024
The change in bazelbuild#21702 only fixed the buildozer fixup messages for `java_*` actions entirely defined in Starlark. This commit makes the analogous change to the remaining native actions. Related to bazelbuild#20486 and bazelbuild#21702 Closes bazelbuild#21827. PiperOrigin-RevId: 623253302 Change-Id: Iadc2b0d8ce64f359b921ad7a7c489111a3a29997
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Apr 10, 2024
The change in bazelbuild#21702 only fixed the buildozer fixup messages for `java_*` actions entirely defined in Starlark. This commit makes the analogous change to the remaining native actions. Related to bazelbuild#20486 and bazelbuild#21702 Closes bazelbuild#21827. PiperOrigin-RevId: 623253302 Change-Id: Iadc2b0d8ce64f359b921ad7a7c489111a3a29997
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Apr 10, 2024
The change in bazelbuild#21702 only fixed the buildozer fixup messages for `java_*` actions entirely defined in Starlark. This commit makes the analogous change to the remaining native actions. Related to bazelbuild#20486 and bazelbuild#21702 Closes bazelbuild#21827. PiperOrigin-RevId: 623253302 Change-Id: Iadc2b0d8ce64f359b921ad7a7c489111a3a29997
sgowroji
removed
the
awaiting-PR-merge
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
The change in bazelbuild#21702 only fixed the buildozer fixup messages for `java_*` actions entirely defined in Starlark. This commit makes the analogous change to the remaining native actions. Related to bazelbuild#20486 and bazelbuild#21702 Closes bazelbuild#21827. PiperOrigin-RevId: 623253302 Change-Id: Iadc2b0d8ce64f359b921ad7a7c489111a3a29997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #21702 only fixed the buildozer fixup messages for
java_*actions entirely defined in Starlark. This commit makes the analogous change to the remaining native actions.Related to #20486 and #21702