Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add java_runtime attribute to java_binary and java_test #22881

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add java_runtime attribute to java_binary and java_test #22881

wants to merge 1 commit into from

Conversation

timothyg-stripe
Copy link
Contributor

This is intended to be a conversation-starter for #22866. Note that the implementation is quite straightforward.

@timothyg-stripe timothyg-stripe mentioned this pull request Jun 24, 2024
Open
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jun 24, 2024
@timothyg-stripe timothyg-stripe changed the title Add java_runtime option to java_binary and java_test Add java_runtime attruvyte to java_binary and java_test Jun 25, 2024
@timothyg-stripe timothyg-stripe force-pushed the java-runtime-attr branch 2 times, most recently from 494304b to ddbffc3 Compare June 25, 2024 00:53
@timothyg-stripe timothyg-stripe changed the title Add java_runtime attruvyte to java_binary and java_test Add java_runtime attribute to java_binary and java_test Jun 25, 2024
@sgowroji sgowroji added the team-Rules-Java Issues for Java rules label Jun 25, 2024
@timothyg-stripe
Copy link
Contributor Author

@hvadehra @cushon I wonder what you all think of this. For what it's worth, this PR only changes Bazel rules. Blaze should be unaffected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timothyg-stripe @sgowroji