[7.3.0] Deduplicate locally executed path mapped spawns #23069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When path mapping is enabled, different `Spawn`s in the same build can have identical `RemoteAction.ActionKey`s and can thus provide remote cache hits for each other. However, cache hits are only possible after the first local execution has concluded and uploaded its result to the cache. To avoid unnecessary duplication of local work, the first `Spawn` for each `RemoteAction.ActionKey` is tracked until its results have been uploaded and all other concurrently scheduled `Spawn`s wait for it and then copy over its local outputs. Fixes bazelbuild#21043 Closes bazelbuild#22556. PiperOrigin-RevId: 655097996 Change-Id: I4368f9210c67a306775164d252aae122d8b46f9b
fmeum
changed the title
github-actions
bot
added
awaiting-review
|
@tjgq can you please take a look at this one? The 7.3.0RC1 is scheduled for next Monday, July 29th. Thanks! |
|
@tjgq friendly ping |
meteorcloudy
approved these changes
Jul 29, 2024
Merged
via the queue into
bazelbuild:release-7.3.0
with commit Jul 29, 2024
ffe1df5
52 checks passed
github-actions
bot
removed
the
awaiting-review
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Aug 13, 2024
…lbuild#23069)" This reverts commit ffe1df5. Causes race conditions, see bazelbuild#23288 for details.
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Sep 19, 2024
…elbuild#23069)" This reverts commit 371fbf6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When path mapping is enabled, different
Spawns in the same build can have identicalRemoteAction.ActionKeys and can thus provide remote cache hits for each other. However, cache hits are only possible after the first local execution has concluded and uploaded its result to the cache.To avoid unnecessary duplication of local work, the first
Spawnfor eachRemoteAction.ActionKeyis tracked until its results have been uploaded and all other concurrently scheduledSpawns wait for it and then copy over its local outputs.Fixes #21043
Closes #22556.
PiperOrigin-RevId: 655097996
Change-Id: I4368f9210c67a306775164d252aae122d8b46f9b
Closes #23060