Set oldest_content_accepted for remote downloader requests without the checksum #23970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
reviewed
Oct 14, 2024
| @@ -90,6 +93,8 @@ public class GrpcRemoteDownloader implements AutoCloseable, Downloader { | |||
| // value when both are present. | |||
| private static final String QUALIFIER_HTTP_HEADER_URL_PREFIX = "http_header_url:"; | |||
|
|
|||
| private Clock clock = Clock.systemUTC(); | |||
There was a problem hiding this comment.
Instead of storing a clock here, you can use com.google.devtools.build.lib.clock.BlazeClock#instance, which is still injectable for testing purposes.
There was a problem hiding this comment.
Thanks for the tip. I replaced the usage of java.time.Clock with com.google.devtools.build.lib.clock.BlazeClock and made appropriate changes to remove the manual property injection into the GrpcRemoteDownloader class.
mislavmandaricaxilis
force-pushed
the
master
branch
from
dd41a68 to
be0c92a
Compare
mislavmandaricaxilis
force-pushed
the
master
branch
from
be0c92a to
9fe8968
Compare
fmeum
approved these changes
Oct 14, 2024
src/main/java/com/google/devtools/build/lib/remote/downloader/GrpcRemoteDownloader.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Fabian Meumertzheim <[email protected]>
github-actions
bot
added
team-Remote-Exec
|
@coeuvre Please take a look |
coeuvre
approved these changes
Oct 14, 2024
coeuvre
added
awaiting-PR-merge
|
@bazel-io fork 8.0.0 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Oct 15, 2024
…e checksum This PR address the bazelbuild#23932 issue with remote downloader. Closes bazelbuild#23970. PiperOrigin-RevId: 686180819 Change-Id: Ia36c5793622bd1ac1fdaa9ef1326ddc385a5a01f
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
…thout the checksum (#23995) This PR address the #23932 issue with remote downloader. Closes #23970. PiperOrigin-RevId: 686180819 Change-Id: Ia36c5793622bd1ac1fdaa9ef1326ddc385a5a01f Commit 60638af Co-authored-by: Mislav Mandaric <[email protected]>
|
The changes in this PR have been included in Bazel 8.0.0 RC2. Please test out the release candidate and report any issues as soon as possible. |
|
@fmeum @iancha1992 would it be possible to backport this to Bazel v7? |
|
@bazel-io fork 7.5.0 |
fmeum
pushed a commit
to fmeum/bazel
that referenced
this pull request
Jan 7, 2025
…thout the checksum This PR address the bazelbuild#23932 issue with remote downloader. Closes bazelbuild#23970. PiperOrigin-RevId: 686180819 Change-Id: Ia36c5793622bd1ac1fdaa9ef1326ddc385a5a01f (cherry picked from commit 60638af)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the #23932 issue with remote downloader.