-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.4.0] Add a string-to-label-dict attribute type. #23998
[7.4.0] Add a string-to-label-dict attribute type. #23998
Conversation
This really just exposes the existing LABEL_DICT_UNARY type that already exists in Java. Other than writing some boring conversion logic, all pieces fell together pretty pleasantly. Work towards #7989. That one calls for a string-to-label-list-dict type, but I'm planning to resolve that as WAI, since string-to-label-dict is close enough. RELNOTES: None. PiperOrigin-RevId: 686415025 Change-Id: Ib07ada7ab2ede95220ed1cc2d3569996fc4afb88
39b1a80
to
42ff626
Compare
How important is this? We are already at rc2 for 7.4.0, we would like to push back non critical changes and avoid delaying the release further. |
Not very, I'd say. I sent out this pull request spurred by @fmeum 's comment #7989 (comment) that if we don't backport this to 7.4.0, it'll take a much longer time for rule sets to make use of this new attribute type. It wasn't complicated, so I thought it was worthwhile but I was not aware of the release schedule of 7.4.0. |
Hmm, this sounds like it's probably worth another rc. |
FYI: unfortunately this cherry-pick was done without cherry-picking related updates to AttributeInfoExtractor.java, so Stardoc + Bazel 7.4/5 will fail on .bzl file using |
7.5.0 is still open |
Indeed; I would prefer that we take this chance to cherry-pick a proper fix, as 7.5.0 is still waiting on the merge of a separate PR, and will have another RC next Monday. |
This really just exposes the existing LABEL_DICT_UNARY type that already exists in Java.
Other than writing some boring conversion logic, all pieces fell together pretty pleasantly.
Work towards #7989. That one calls for a string-to-label-list-dict type, but I'm planning to resolve that as WAI, since string-to-label-dict is close enough.
RELNOTES: None.
PiperOrigin-RevId: 686415025
Change-Id: Ib07ada7ab2ede95220ed1cc2d3569996fc4afb88