Streamline ModuleExtensionId#toString()
#24450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
meteorcloudy
approved these changes
Nov 22, 2024
meteorcloudy
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
fmeum
pushed a commit
to fmeum/bazel
that referenced
this pull request
Jan 7, 2025
Currently `ModuleExtensionId#toString()` uses the default Java record repr, which isn't very user-friendly. There's really no reason not to use the `asTargetString()` method instead. This PR just renames `asTargetString()` to `toString()` and updates all call sites. Closes bazelbuild#24450. PiperOrigin-RevId: 700050362 Change-Id: I82238d2134e1642694f0b20235fcfe9307ceaa7d (cherry picked from commit d23421a)
fmeum
pushed a commit
to fmeum/bazel
that referenced
this pull request
Jan 7, 2025
Currently `ModuleExtensionId#toString()` uses the default Java record repr, which isn't very user-friendly. There's really no reason not to use the `asTargetString()` method instead. This PR just renames `asTargetString()` to `toString()` and updates all call sites. Closes bazelbuild#24450. PiperOrigin-RevId: 700050362 Change-Id: I82238d2134e1642694f0b20235fcfe9307ceaa7d (cherry picked from commit d23421a) Fix edge cases in lockfile handling * Don't run the core logic when `--lockfile_mode` is `off` or `error` but the command doesn't forward options to Skyframe. * Honor `reproducible` per extension eval factor, not per extension. * Fix encoding conflict between isolation key and `use_repo_rule`'s fake extension names This doesn't require a lockfile version bump as `use_repo_rule`'s fake extension (so far) isn't included in the lockfile. Work towards bazelbuild#24723 Closes bazelbuild#24754. PiperOrigin-RevId: 712623562 Change-Id: I61fd439539031a01ddec4488276ff2d0484849f2 (cherry picked from commit cfda178)
meteorcloudy
pushed a commit
that referenced
this pull request
Jan 8, 2025
… lockfile handling (#24845) ### Streamline `ModuleExtensionId#toString()` Currently `ModuleExtensionId#toString()` uses the default Java record repr, which isn't very user-friendly. There's really no reason not to use the `asTargetString()` method instead. This PR just renames `asTargetString()` to `toString()` and updates all call sites. Closes #24450. PiperOrigin-RevId: 700050362 Change-Id: I82238d2134e1642694f0b20235fcfe9307ceaa7d (cherry picked from commit d23421a) ### Fix edge cases in lockfile handling * Don't run the core logic when `--lockfile_mode` is `off` or `error` but the command doesn't forward options to Skyframe. * Honor `reproducible` per extension eval factor, not per extension. * Fix encoding conflict between isolation key and `use_repo_rule`'s fake extension names This doesn't require a lockfile version bump as `use_repo_rule`'s fake extension (so far) isn't included in the lockfile. Work towards #24723 Closes #24754. PiperOrigin-RevId: 712623562 Change-Id: I61fd439539031a01ddec4488276ff2d0484849f2 (cherry picked from commit cfda178) Fixes #24754 Co-authored-by: Xdng Yng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ModuleExtensionId#toString()uses the default Java record repr, which isn't very user-friendly. There's really no reason not to use theasTargetString()method instead. This PR just renamesasTargetString()totoString()and updates all call sites.