-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a persistent lockfile to speed up reproducible extensions #24757
Open
fmeum
wants to merge
8
commits into
bazelbuild:master
Choose a base branch
from
fmeum:24723-reproducible-lockfile
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't run the core logic when `--lockfile_mode` is `off` or `error` but the command doesn't forward options to Skyframe. * Honor `reproducible` per extension eval factor, not per extension.
fmeum
force-pushed
the
24723-reproducible-lockfile
branch
3 times, most recently
from
December 19, 2024 12:48
5b6bc19
to
7d5f6ee
Compare
fmeum
force-pushed
the
24723-reproducible-lockfile
branch
2 times, most recently
from
December 19, 2024 18:54
082e2fb
to
02e2e2c
Compare
fmeum
force-pushed
the
24723-reproducible-lockfile
branch
from
December 28, 2024 22:01
b713852
to
7e67e07
Compare
fmeum
changed the title
24723 reproducible lockfile
Use a persistent lockfile to speed up reproducible extensions
Dec 29, 2024
Notes for the review:
|
fmeum
requested review from
a team,
gregestren,
fweikert,
Wyverald and
meteorcloudy
as code owners
December 29, 2024 13:03
github-actions
bot
added
team-Configurability
platforms, toolchains, cquery, select(), config transitions
team-ExternalDeps
External dependency handling, remote repositiories, WORKSPACE file.
team-Documentation
Documentation improvements that cannot be directly linked to other team labels
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Dec 29, 2024
fmeum
removed
the
team-Configurability
platforms, toolchains, cquery, select(), config transitions
label
Dec 29, 2024
fmeum
removed
the
team-Documentation
Documentation improvements that cannot be directly linked to other team labels
label
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting-review
PR is awaiting review from an assigned reviewer
team-ExternalDeps
External dependency handling, remote repositiories, WORKSPACE file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducible extensions are not included in the regular lockfile in order to keep it small and less prone to merge conflicts. But reproducible extensions can still take significant time to evaluate, which currently happens on every server restart.
This commit makes it so that Bazel maintains an additional lockfile, stored under the output base and not visible to the user. It only records information that remain correct indefinitely, such as the results of reproducible extensions as well as hashes of module files from registries. See the comments on BazelLockFileValue for a detailed comparison of the contents of the two lockfiles.
Fixes #24723