Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --incompatible_compact_repo_mapping #24809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 29, 2024

With the flag enabled, <binary>.repo_mapping contains

+deps+*,aaa,_main
+deps+*,dep,+deps+dep1
+deps+*,dep1,+deps+dep1
+deps+*,dep2,+deps+dep2
+deps+*,dep3,+deps+dep3

instead of

+deps+dep1,aaa,_main
+deps+dep1,dep,+deps+dep1
+deps+dep1,dep1,+deps+dep1
+deps+dep1,dep2,+deps+dep2
+deps+dep1,dep3,+deps+dep3
+deps+dep2,aaa,_main
+deps+dep2,dep,+deps+dep1
+deps+dep2,dep1,+deps+dep1
+deps+dep2,dep2,+deps+dep2
+deps+dep2,dep3,+deps+dep3
...

for the deps module extension.

Runfiles libraries have to be updated to find entries using the new format.

Work towards #24808

@fmeum fmeum force-pushed the 24808-compact-repo-mapping branch 3 times, most recently from 22fde54 to 2601e43 Compare December 30, 2024 08:24
@fmeum fmeum force-pushed the 24808-compact-repo-mapping branch from 2601e43 to 9b3e9fc Compare December 30, 2024 08:26
@fmeum fmeum marked this pull request as ready for review December 30, 2024 08:29
@fmeum fmeum requested review from a team and lberki as code owners December 30, 2024 08:29
@fmeum fmeum requested review from aranguyen and removed request for a team, lberki and aranguyen December 30, 2024 08:29
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions team-Rules-Python Native rules for Python awaiting-review PR is awaiting review from an assigned reviewer labels Dec 30, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 30, 2024

@Wyverald Should we ask runfiles libraries to perform a linear match on all lines with prefixes? That's O(num extensions), but avoids specifying the separator char or scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions team-Rules-Python Native rules for Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant