Reduce retained memory of UnresolvedSymlinkAction
#24831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
requested review from
gregestren and
tjgq
and removed request for
a team
github-actions
bot
added
team-Configurability
The required conversion to `PathFragment` can be performed during execution, which avoids retaining a new `PathFragment` instance per action.
fmeum
force-pushed
the
unresolved-symlink-memory
branch
from
397b456 to
3765930
Compare
fmeum
changed the title
UnresolvedSymlinkActionUnresolvedSymlinkAction
tjgq
approved these changes
Jan 8, 2025
tjgq
added
awaiting-PR-merge
|
@bazel-io fork 8.1.0 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 9, 2025
The required conversion to `PathFragment` can be performed during execution, which avoids retaining a new `PathFragment` instance per action. Closes bazelbuild#24831. PiperOrigin-RevId: 713577830 Change-Id: I2781ea979a3c97abf5a519acd5d3d6a668dd1f77
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
The required conversion to `PathFragment` can be performed during execution, which avoids retaining a new `PathFragment` instance per action. Closes #24831. PiperOrigin-RevId: 713577830 Change-Id: I2781ea979a3c97abf5a519acd5d3d6a668dd1f77 Commit 293be8a Co-authored-by: Fabian Meumertzheim <[email protected]> Co-authored-by: Ian (Hee) Cha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The required conversion to
PathFragmentcan be performed during execution, which avoids retaining a newPathFragmentinstance per action.