Inject metadata for UnresolvedSymlinkAction
#24832
Open
+26
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metadata of the output is known and does not require IO to create.
fmeum
requested review from
katre and
tjgq
and removed request for
a team and
katre
github-actions
bot
added
team-Performance
coeuvre
reviewed
Jan 7, 2025
| @@ -81,6 +82,16 @@ public ActionResult execute(ActionExecutionContext actionExecutionContext) | |||
| throw new ActionExecutionException(message, e, this, false, code); | |||
| } | |||
|
|
|||
| // Action filesystems are responsible for their own metadata injection. | |||
| if (actionExecutionContext.getActionFileSystem() == null) { | |||
| actionExecutionContext | |||
There was a problem hiding this comment.
I am wondering whether this can be done inside skyframe (i.e. we don't need to add special case for action filesystem)?
cc @tjgq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata of the output is known and does not require IO to create.