Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject unresolved symlinks with BwoB #24833

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 6, 2025

Creating unresolved symlinks locally when building with --remote_download_outputs=minimal results in unnecessary I/O and may not even be supported by the host (e.g. on Windows). Instead, only create it in the remote action file system.

@fmeum fmeum force-pushed the unresolved-symlink-bwob branch 5 times, most recently from e073054 to 837ccff Compare January 7, 2025 08:37
fmeum added 2 commits January 7, 2025 10:35
Creating unresolved symlinks locally when building with `--remote_download_outputs=minimal` results in unnecessary I/O and may not even be supported by the host (e.g. on Windows). Instead, only create it in the remote action file system.
@fmeum fmeum force-pushed the unresolved-symlink-bwob branch from 837ccff to 7438799 Compare January 7, 2025 09:35
@fmeum fmeum marked this pull request as ready for review January 7, 2025 09:51
@fmeum fmeum requested a review from a team as a code owner January 7, 2025 09:51
@github-actions github-actions bot added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Jan 7, 2025
@meisterT meisterT requested a review from tjgq January 8, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant