Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shorthand display form in Label#debugPrint #24840

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 7, 2025

This makes the output, which is meant to be friendly to humans, more concise. If users want //foo to be printed as //foo:foo, they can specify sep = "" and also print :foo, but stripping the name off is not possible without this change.

@fmeum fmeum requested review from Wyverald and meteorcloudy January 7, 2025 06:51
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 7, 2025

@bazel-io fork 8.1.0

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 7, 2025
This makes the output, which is meant to be friendly to humans, more concise. If users want `//foo` to be `print`ed as `//foo:foo`, they can specify `sep = ""` and also print `:foo`, but stripping the name off is not possible without this change.
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 7, 2025
@copybara-service copybara-service bot closed this in e0fada9 Jan 8, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 8, 2025
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 8, 2025
This makes the output, which is meant to be friendly to humans, more concise. If users want `//foo` to be `print`ed as `//foo:foo`, they can specify `sep = ""` and also print `:foo`, but stripping the name off is not possible without this change.

Closes bazelbuild#24840.

PiperOrigin-RevId: 713207601
Change-Id: I474fc4eccb1419304368a5c90a22c13b2197b699
@fmeum fmeum deleted the shorthand-print branch January 8, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants