Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.5.0] Don't show fixup warnings during bazel mod tidy #24846

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 7, 2025

The warnings tell the user to run bazel mod tidy, which is very confusing.

Fixes #24495

Closes #24729.

PiperOrigin-RevId: 708007222
Change-Id: I60dc889281a776bbf08a7f9537272d7692cce1d8
(cherry picked from commit 455ddb7)

Fixes #24740

@fmeum fmeum requested a review from a team as a code owner January 7, 2025 12:54
@fmeum fmeum requested review from Wyverald and removed request for a team January 7, 2025 12:54
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Jan 7, 2025
The warnings tell the user to run `bazel mod tidy`, which is very confusing.

Fixes bazelbuild#24495

Closes bazelbuild#24729.

PiperOrigin-RevId: 708007222
Change-Id: I60dc889281a776bbf08a7f9537272d7692cce1d8
(cherry picked from commit 455ddb7)
@fmeum fmeum requested a review from a team January 7, 2025 13:04
@iancha1992 iancha1992 enabled auto-merge January 7, 2025 19:06
@iancha1992 iancha1992 added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@meteorcloudy meteorcloudy merged commit 09c29e3 into bazelbuild:release-7.5.0 Jan 8, 2025
50 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jan 8, 2025
@fmeum fmeum deleted the 7.5.0-24740 branch January 8, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants