Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.5.0] Record repo mapping entries for labels in module extension tags #25115

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

Wyverald
Copy link
Member

The mapping of an apparent name in a module extension tag's attr.label attribute to the corresponding canonical name has to be recorded in the lockfile so that instantiated repo rules don't reference the stale repos.

Fixes #25063

Closes #25067.

PiperOrigin-RevId: 720592796
Change-Id: Ia202ca4a8482a81da8085ee18ecaca5fe233bddb

@Wyverald Wyverald requested a review from a team as a code owner January 28, 2025 19:38
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Jan 28, 2025
The mapping of an apparent name in a module extension tag's `attr.label` attribute to the corresponding canonical name has to be recorded in the lockfile so that instantiated repo rules don't reference the stale repos.

Fixes #25063

Closes #25067.

PiperOrigin-RevId: 720592796
Change-Id: Ia202ca4a8482a81da8085ee18ecaca5fe233bddb
@Wyverald Wyverald force-pushed the wyv-750-repomapping branch from 5d9b2b6 to c37e8a3 Compare January 28, 2025 19:45
@iancha1992 iancha1992 enabled auto-merge January 28, 2025 19:56
@Wyverald Wyverald force-pushed the wyv-750-repomapping branch from f176f33 to 8e3b41a Compare January 28, 2025 21:14
@iancha1992 iancha1992 added this pull request to the merge queue Jan 28, 2025
Merged via the queue into release-7.5.0 with commit d4b904f Jan 28, 2025
52 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jan 28, 2025
@Wyverald Wyverald deleted the wyv-750-repomapping branch January 29, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants