Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.1.1] Fall back to rctx.name if $original_name is empty #25310

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

bazel-io
Copy link
Member

The default for the attribute is the empty string, not null.

Fixes #25286

Closes #25296.

PiperOrigin-RevId: 728298504
Change-Id: Ibc7209e248c3abb57a5fb2487e7dab7202960bbd

Commit fa7900a

The default for the attribute is the empty string, not `null`.

Fixes bazelbuild#25286

Closes bazelbuild#25296.

PiperOrigin-RevId: 728298504
Change-Id: Ibc7209e248c3abb57a5fb2487e7dab7202960bbd
@bazel-io bazel-io requested a review from a team as a code owner February 18, 2025 19:50
@bazel-io bazel-io added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Feb 18, 2025
@iancha1992 iancha1992 requested a review from Wyverald February 18, 2025 20:03
@iancha1992 iancha1992 enabled auto-merge (squash) February 18, 2025 20:03
@iancha1992 iancha1992 merged commit d81c123 into bazelbuild:release-8.1.1 Feb 18, 2025
46 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants