Run tests after building java tools. #8205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iirina
force-pushed
the
run_tests_after_building_java_tools
branch
2 times, most recently
from
5b7da11 to
5392b4e
Compare
iirina
force-pushed
the
run_tests_after_building_java_tools
branch
3 times, most recently
from
8dd23d0 to
cf87b44
Compare
lberki
reviewed
May 9, 2019
iirina
force-pushed
the
run_tests_after_building_java_tools
branch
from
cf87b44 to
71799e4
Compare
|
@lberki comments addressed! |
lberki
approved these changes
May 9, 2019
lberki
approved these changes
May 9, 2019
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
This PR adds a shell integration test for the java rules that is run with the java toolchain of the java tools build from head. The test is created and run by `src/upload_java_tools.sh` which is used by the Buildkite pipeline to generate the java tools zip. The generated java tools zip is uploaded to GCS only if the test succeeded. This provides testing before creating release candidates for the java tools. Closes bazelbuild#8205. PiperOrigin-RevId: 247408063
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a shell integration test for the java rules that is run with the java toolchain of the java tools build from head. The test is created and run by
src/upload_java_tools.shwhich is used by the Buildkite pipeline to generate the java tools zip.The generated java tools zip is uploaded to GCS only if the test succeeded. This provides testing before creating release candidates for the java tools.