Windows, bazel run: don't join all args into argv0 #8287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To "bazel run" a binary, the RunCommand creates an ExecRequest and sends it to the Bazel client, which then fulfills the request. In PR bazelbuild#8241, RunCommand merged all command line arguments and added that to the request as a single argv entry. The client uses the first argv element as the executable, but if all arguments are joined into one string then argv0 contains the whole argument vector as a single string. Unfortunately the test didn't catch this because it didn't attempt passing any arguments. Fixes bazelbuild#8229 See bazelbuild#8240
laszlocsomor
changed the title
meteorcloudy
approved these changes
May 10, 2019
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
To "bazel run" a binary, the RunCommand creates an ExecRequest and sends it to the Bazel client, which then runs the binary as the client's subprocess. In PR bazelbuild#8241, RunCommand merged all command line arguments and added that to the request as a single argv entry. The client uses the first argv element as the executable, but if all arguments are joined into one string then argv0 contains the whole argument vector as a single string. Unfortunately the test didn't catch this because it didn't attempt passing any arguments. Fixes bazelbuild#8229 See bazelbuild#8240 Closes bazelbuild#8287. PiperOrigin-RevId: 247590904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To "bazel run" a binary, the RunCommand creates an
ExecRequest and sends it to the Bazel client,
which then runs the binary as the client's
subprocess.
In PR #8241, RunCommand merged all command line
arguments and added that to the request as a
single argv entry. The client uses the first argv
element as the executable, but if all arguments
are joined into one string then argv0 contains the
whole argument vector as a single string.
Unfortunately the test didn't catch this because
it didn't attempt passing any arguments.
Fixes #8229
See #8240