Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote: deprecated --remote_local_fallback_strategy #8307

Conversation

ishikhman
Copy link
Contributor

The flag is no-op because the flag --strategy can now accept a list of strategies, therefore a fallback specific for particular strategy is not possible. See #7480 for details.

RELNOTES: deprecated --remote_local_fallback_strategy. Use --strategy=remote,local instead. See #7480.

@ishikhman ishikhman self-assigned this May 13, 2019
@ishikhman ishikhman marked this pull request as ready for review May 14, 2019 21:37
@ishikhman
Copy link
Contributor Author

I've double checked - there are tests for a local fallback with a list-based strategy.

@ishikhman ishikhman force-pushed the ishikhman-deprecate-remote-local-fallback-strategy branch from 1747609 to 2516587 Compare May 16, 2019 19:26
The flag is no-op because the flag --strategy can now accept a list of strategies, therefore a fallback specific for particular strategy is not possible. See bazelbuild#7480 for details.

RELNOTES: deprecated --remote_local_fallback_strategy. Use `--strategy=remote,local` instead. See bazelbuild#7480.
@ishikhman ishikhman force-pushed the ishikhman-deprecate-remote-local-fallback-strategy branch from 2516587 to dfa47c3 Compare May 16, 2019 19:27
@buchgr
Copy link
Contributor

buchgr commented May 16, 2019

LGTM

@bazel-io bazel-io closed this in 4409982 May 17, 2019
irengrig pushed a commit to irengrig/bazel that referenced this pull request Jun 18, 2019
The flag is no-op because the flag --strategy can now accept a list of strategies, therefore a fallback specific for particular strategy is not possible. See bazelbuild#7480 for details.

RELNOTES: deprecated --remote_local_fallback_strategy. Use `--strategy=remote,local` instead. See bazelbuild#7480.

Closes bazelbuild#8307.

PiperOrigin-RevId: 248804091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants