Also generate import-style targets with Gazelle
#1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the repo uses checked-in build files, it should support both the `import` and `go_default_library` naming conventions supported by Gazelle to ensure that it works with all possible values of the `gazelle:go_naming_convention_external` directive. This is achieved by using `gazelle:go_naming_convention import_alias`.
|
CC @cgrindel |
|
Former 'go_default_test` rules don't have aliases, is that expected? Is that not part of the convention anymore? |
|
I'm not entirely sure whether this changed at some point, but as far as I understood the convention the aliases exist just to ensure references from other repos to this repo aren't broken. Other repos would not reference tests, so aliases for them shouldn't be needed. |
|
@vladmos Friendly ping on this, it would definitely make downstream users' lives easier. :-) |
|
@fmeum Do you need a new release with these changes or just having them in the repo enough for now? |
|
@vladmos This particular change is fine without a release - in fact, Go doesn't see the releases since their major versions don't match the import path. |
apattidb
pushed a commit
to databricks/buildtools
that referenced
this pull request
May 10, 2024
Since the repo uses checked-in build files, it should support both the `import` and `go_default_library` naming conventions supported by Gazelle to ensure that it works with all possible values of the `gazelle:go_naming_convention_external` directive. This is achieved by using `gazelle:go_naming_convention import_alias`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the repo uses checked-in build files, it should support both the
importandgo_default_librarynaming conventions supported by Gazelle to ensure that it works with all possible values of thegazelle:go_naming_convention_externaldirective.This is achieved by using
gazelle:go_naming_convention import_alias.Fixes bazel-contrib/bazel-gazelle#1557