Update GitHub Action for BCR Reviewer #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Merged the module maintainer notifier and the PR approval into one action, which can be distinguished by the "action-type" input. - Implement a new functionality to dismiss stale approvals from all reviewer. The default "Dismiss stale pull request approvals when new commits are pushed" option from GitHub doesn't dimiss approvals from users who is not a repo maintainer.
|
Tested in meteorcloudy/bazel-central-registry#20 with configs located at https://github.com/meteorcloudy/bazel-central-registry/tree/main/.github/workflows |
Wyverald
reviewed
Mar 12, 2024
|
The 'dismiss review' config LGTM! (for posterity: https://github.com/meteorcloudy/bazel-central-registry/blob/main/.github/workflows/dismiss-approvals.yml) |
Wyverald
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
action, which can be distinguished by the "action-type" input.
The default
Dismiss stale pull request approvals when new commits are pushedoption from GitHub doesn't dismiss approvals from users who is not a repo maintainer. This helps address the concern that a local commit was made before the approval but pushed after it. See Add GitHub Actions to auto-review BCR PRs bazel-central-registry#1549 (comment)