Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for --incompatible_disallow_legacy_py_provider #538

Closed
wants to merge 1 commit into from
Closed

Fix for --incompatible_disallow_legacy_py_provider #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aspect/intellij_info_impl.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def update_set_in_dict(input_dict, key, other_set):

def collect_py_info(target, ctx, semantics, ide_info, ide_info_file, output_groups):
"""Updates Python-specific output groups, returns false if not a Python target."""
if not hasattr(target, "py") or _is_language_specific_proto_library(ctx, target):
if not PyInfo in target or _is_language_specific_proto_library(ctx, target):
return False

py_semantics = getattr(semantics, "py", None)
Expand All @@ -216,7 +216,7 @@ def collect_py_info(target, ctx, semantics, ide_info, ide_info_file, output_grou
sources = sources_from_target(ctx),
launcher = py_launcher,
)
transitive_sources = target.py.transitive_sources
transitive_sources = target[PyInfo].transitive_sources

update_set_in_dict(output_groups, "intellij-info-py", depset([ide_info_file]))
update_set_in_dict(output_groups, "intellij-compile-py", transitive_sources)
Expand Down