-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix action_env for ipa post processor #2232
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@MIP9 Can you sign the CLA? |
Can you rebase off master? Looks like buildifier is reporting outdated warnings from an old revision. Other CI issues are probably related to the current GitHub's incident. |
c4b6636
to
f3fe5b3
Compare
f3fe5b3
to
31c218f
Compare
this is also being fixed in bazel with bazelbuild/bazel#18235 |
@keith Does this PR still make sense? Or do you think better leave as is and wait for bazel 6.4.0? |
yea that's a good question, can you test with 6.4 and see if it really does fix it? |
Seems the cherrypick did not make it to 6.4.0 yet, and the commit has not been built with bazel ci (so there is no prebuilt bazel binary), so I am not sure how to test it atm 😅 |
If you use bazelisk you can set |
Or build a bazel binary with that patch. |
note that with bazel 7.x HEAD of rules_apple now enables that env for all actions (or tries too, possible I missed some) |
Environment variables that provided by
--action_env
flag are not accessible on ipa_post_processor .sh script.There is fix for it.