Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding BCR configuration and bump version to 5.3.2 #73

Merged
merged 4 commits into from
Nov 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .bcr/metadata.template.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"homepage": "https://github.com/bazelbuild/rules_java",
"maintainers": [],
"versions": [],
"yanked_versions": {}
}
8 changes: 8 additions & 0 deletions .bcr/presubmit.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
matrix:
platform: ["centos7", "debian10", "macos", "ubuntu2004", "windows"]
tasks:
verify_build_targets:
name: "Verify build targets"
platform: ${{ platform }}
build_targets:
- "@rules_java//..."
5 changes: 5 additions & 0 deletions .bcr/source.template.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"integrity": "",
"strip_prefix": "{REPO}-{VERSION}",
"url": "https://github.com/{OWNER}/{REPO}/archive/refs/tags/{TAG}.tar.gz"
}
2 changes: 1 addition & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module(
name = "rules_java",
compatibility_level = 1,
version = "5.1.0",
version = "5.3.2",
)

bazel_dep(name = "platforms", version = "0.0.4")
Expand Down
3 changes: 2 additions & 1 deletion distro/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Releasing rules_java

1. Update version in [java/defs.bzl](/java/defs.bzl) and merge it
1. Update version in [java/defs.bzl](/java/defs.bzl),
[MODULE.bazel](/MODULE.bazel) and merge it
2. Build the release running `bazel build //distro:rules_java-{version}`
3. Prepare release notes running `bazel build //distro:relnotes`
4. Create a new release on GitHub
Expand Down
2 changes: 1 addition & 1 deletion java/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ licenses(["notice"])

filegroup(
name = "srcs",
srcs = glob(["**"]),
srcs = glob(["**"]) + ["@//java/private:srcs"],
visibility = ["@//:__pkg__"],
)

Expand Down
2 changes: 1 addition & 1 deletion java/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ load("//java/private:native.bzl", "NativeJavaInfo", "NativeJavaPluginInfo", "nat
# Do not touch: This line marks the end of loads; needed for PR importing.

_MIGRATION_TAG = "__JAVA_RULES_MIGRATION_DO_NOT_USE_WILL_BREAK__"
version = "5.1.0"
version = "5.3.2"

def _add_tags(attrs):
if "tags" in attrs and attrs["tags"] != None:
Expand Down
8 changes: 7 additions & 1 deletion java/private/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,11 @@ licenses(["notice"])
bzl_library(
name = "private",
srcs = ["native.bzl"],
visibility = ["//visibility:public"],
visibility = ["@//java:__pkg__"],
)

filegroup(
name = "srcs",
srcs = glob(["**"]),
visibility = ["@//java:__pkg__"],
)