Fix Android support when running the entire test suite #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
requested review from
ahumesky,
cgruber and
restingbull
as code owners
restingbull
approved these changes
Oct 12, 2023
Bencodes
commented
Oct 12, 2023
| load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe") | ||
| load("@rules_android//android:rules.bzl", "android_sdk_repository") | ||
|
|
||
| maybe( |
There was a problem hiding this comment.
Mirroring what's being done in rules_android https://github.com/bazelbuild/rules_android/blob/main/WORKSPACE.bzlmod#L8
Bencodes
commented
Oct 12, 2023
| load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe") | ||
| load("@rules_android//android:rules.bzl", "android_sdk_repository") | ||
|
|
||
| maybe( |
There was a problem hiding this comment.
Mirroring what's being done in rules_android https://github.com/bazelbuild/rules_android/blob/main/WORKSPACE.bzlmod#L8
There was a problem hiding this comment.
This will only get called when building within the rules_kotlin project. This repo shouldn't be initialized when depending on rules_kotlin as a set of rules.
Bencodes
commented
Oct 12, 2023
| @@ -24,6 +24,10 @@ use_repo( | |||
|
|
|||
| register_toolchains("//kotlin/internal:default_toolchain") | |||
|
|
|||
| # TODO(bencodes) We should be able to remove this once rules_android has rolled out official Bzlmod support | |||
| remote_android_extensions = use_extension("@bazel_tools//tools/android:android_extensions.bzl", "remote_android_tools_extensions") | |||
There was a problem hiding this comment.
Mirroring what's being done in rules_android https://github.com/bazelbuild/rules_android/blob/main/MODULE.bazel#L63-L64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project fails to build when using //... without the Android SDK and tools being instantiated.
This mirrors exactly what is being done in the
rules_androidrepo.