Fix workspace resolution for development #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restingbull
force-pushed
the
restingbull/fix-workspace
branch
4 times, most recently
from
23909ad to
ffce528
Compare
restingbull
force-pushed
the
restingbull/fix-workspace
branch
2 times, most recently
from
52cd31f to
513f4e0
Compare
restingbull
force-pushed
the
restingbull/fix-workspace
branch
from
513f4e0 to
bacfec5
Compare
restingbull
force-pushed
the
restingbull/fix-workspace
branch
from
dcacaf1 to
a41419b
Compare
restingbull
force-pushed
the
restingbull/fix-workspace
branch
2 times, most recently
from
eb4649b to
3cdfe62
Compare
restingbull
force-pushed
the
restingbull/fix-workspace
branch
from
3cdfe62 to
9204d5e
Compare
restingbull
force-pushed
the
restingbull/fix-workspace
branch
from
e3d3ede to
b9fc275
Compare
restingbull
force-pushed
the
restingbull/fix-workspace
branch
from
d6d0c77 to
d714790
Compare
restingbull
requested review from
ahumesky,
cgruber,
Bencodes and
nkoroste
as code owners
restingbull
force-pushed
the
restingbull/fix-workspace
branch
from
d714790 to
a018fe3
Compare
Bencodes
reviewed
Dec 6, 2024
.bazelrc
Outdated
| @@ -3,6 +3,10 @@ common --enable_bzlmod=true | |||
| common:rbe --java_runtime_version=11 | |||
| common:rbe --tool_java_runtime_version=11 | |||
|
|
|||
| common:workspace --enable_bzlmod=false --enable_workspace=true | |||
| #common:workspace --enable_platform_specific_config | |||
There was a problem hiding this comment.
These are commented out, is that intentional?
There was a problem hiding this comment.
Yeah, tried using a hermetic toolchain. It didn't help.
Bencodes
reviewed
Dec 6, 2024
| deps = [ | ||
| "@rules_proto//proto:defs", | ||
| ], | ||
| # deps = [ |
There was a problem hiding this comment.
Did you mean to leave this commented out?
Bencodes
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align versions tween bzlmod and workspace
Switch to the fancy bazel ci rules for rbe.
Enable RBE for integration tests (huuuuge difference)
fixes: #1230