-
Notifications
You must be signed in to change notification settings - Fork 559
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(bzlmod): a minimal entry_point support and a test
Add an `entry_point` macro to the repo generated by the `pip.parse` extension. This works by using the canonical label literal, so should work without users needing to add any "spoke" repos to the `use_repo` statement. We test this by having an extra folder in the `bzlmod` example.
- Loading branch information
Showing
7 changed files
with
82 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,7 @@ py_binary( | |
py_test( | ||
name = "test", | ||
srcs = ["test.py"], | ||
main = "test.py", | ||
deps = [":lib"], | ||
) | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
load("@pip//:requirements.bzl", "entry_point") | ||
load("@rules_python//python:defs.bzl", "py_test") | ||
|
||
alias( | ||
name = "yamllint", | ||
actual = entry_point("yamllint"), | ||
) | ||
|
||
py_test( | ||
name = "entry_point_test", | ||
srcs = ["test_entry_point.py"], | ||
data = [ | ||
":yamllint", | ||
], | ||
env = { | ||
"YAMLLINT_ENTRY_POINT": "$(rlocationpath :yamllint)", | ||
}, | ||
main = "test_entry_point.py", | ||
deps = ["@rules_python//python/runfiles"], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# Copyright 2023 The Bazel Authors. All rights reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import os | ||
import pathlib | ||
import subprocess | ||
import unittest | ||
|
||
from python.runfiles import runfiles | ||
|
||
|
||
class ExampleTest(unittest.TestCase): | ||
def test_entry_point(self): | ||
rlocation_path = os.environ.get("YAMLLINT_ENTRY_POINT") | ||
assert ( | ||
rlocation_path is not None | ||
), "expected 'YAMLLINT_ENTRY_POINT' env variable to be set to rlocation of the tool" | ||
|
||
entry_point = pathlib.Path(runfiles.Create().Rlocation(rlocation_path)) | ||
self.assertTrue(entry_point.exists(), f"'{entry_point}' does not exist") | ||
|
||
proc = subprocess.run( | ||
[str(entry_point), "--version"], | ||
check=True, | ||
stdout=subprocess.PIPE, | ||
stderr=subprocess.PIPE, | ||
) | ||
self.assertEqual(proc.stdout.decode("utf-8").strip(), "yamllint 1.28.0") | ||
|
||
|
||
if __name__ == "__main__": | ||
unittest.main() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters